New function for creating misaligned detector views #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsulaiav
force-pushed
the
main-det-misalign
branch
3 times, most recently
from
c005fc7 to
398185e
Compare
tsulaiav
changed the title
tsulaiav
force-pushed
the
main-det-misalign
branch
from
398185e to
9d1e941
Compare
niermann999
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Looks good already! Some test cases would be good to make sure the detector naturally accesses the misaligned transforms. You could e.g. go through the detector surfaces with the auto sf = tracking_surface{some_surface_descriptor_from_the_detector} class and check that is picks up the correct translation in sf.transform()
tsulaiav
force-pushed
the
main-det-misalign
branch
2 times, most recently
from
7598137 to
e116c5b
Compare
tsulaiav
commented
Dec 12, 2024
tsulaiav
force-pushed
the
main-det-misalign
branch
from
e116c5b to
9ee3668
Compare
niermann999
reviewed
Dec 18, 2024
tsulaiav
force-pushed
the
main-det-misalign
branch
7 times, most recently
from
77fd950 to
b619f1b
Compare
tsulaiav
force-pushed
the
main-det-misalign
branch
3 times, most recently
from
7631548 to
ec59cae
Compare
Introduced a new function `misaligned_detector_view()` that makes a misaligned detector view by combining "static" buffers of the detector (volumes, surfaces, etc.) with a buffer of potentially misaligned transforms. The new mechanism is tested by a new unit test `detector_align_cuda`. A demonstration of the usage of this mechanism added to the `cuda/detector_construction` tutorial code
tsulaiav
force-pushed
the
main-det-misalign
branch
from
ec59cae to
1816ae7
Compare
niermann999
approved these changes
Jan 6, 2025
Sounds good. Thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.